replaced 'iconoir-react' with '@tokens-studio/icons' where possible #532
Conversation
|
packages/graph-editor/src/components/colorPicker/InputPopover.tsx
Outdated
Show resolved
Hide resolved
|
Icons are now imported individually. |
| @@ -1,12 +1,13 @@ | |||
| import { Accordion, Box, Stack, Text, TextInput } from '@tokens-studio/ui'; | |||
| import { DragItem } from './DragItem.js'; | |||
| import { DropPanelStore } from './data.js'; | |||
| import { IconoirProvider, NavArrowRight } from 'iconoir-react'; | |||
| import { IconoirProvider } from 'iconoir-react'; | |||
There was a problem hiding this comment.
Check where this is used, we just need a wrapper around the icons used to make sure they are the correct size
| import { | ||
| PanelGroup, | ||
| PanelItem, | ||
| defaultPanelGroupsFactory, | ||
| } from '@tokens-studio/graph-editor'; | ||
| import { nodeLookup as audioLookup } from '@tokens-studio/graph-engine-nodes-audio'; | ||
| import { nodes as fsNodes } from '@tokens-studio/graph-engine-nodes-fs'; | ||
| import Accessibility from '@tokens-studio/icons/Accessibility.js'; |
There was a problem hiding this comment.
Doesn't look like this package had the new icons package installed
| @@ -1,16 +1,5 @@ | |||
| 'use client'; | |||
|
|
|||
| import { | |||
There was a problem hiding this comment.
Same here, make sure we install the icons package within this package so we don't get any surprises
added @tokens-studio/icons to vscode-extension and ui packages
| <IconoirProvider | ||
| iconProps={{ width: '0.875em', height: '0.875em' }} | ||
| > | ||
| <div style={{ width: '0.875em', height: '0.875em' }}> |
There was a problem hiding this comment.
Does the icon expand correctly into this ? I don't think it has an implicit height & width of 100%
There was a problem hiding this comment.
fyi you can just pass width and height into the icon which is the preferred way of scaling the icon as then the stroke will also adjust
Description
'iconoir-react'with'@tokens-studio/icons'where possibleResolves #530
Type of change